Skip to content

feat(amazonq): send ide diagnostics for inline completions #7561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 10, 2025
Merged

feat(amazonq): send ide diagnostics for inline completions #7561

merged 5 commits into from
Jul 10, 2025

Conversation

@liumofei-amazon
Copy link
Contributor

@liumofei-amazon liumofei-amazon commented Jun 26, 2025

Problem

Adding client side diagnostic data back after inline flare migration

Solution

Migrate existing logic for getting IDE diagnostic info and flow it to LogInlineCompletionSessionResultsParams

Re-using

https://github.com/aws/aws-toolkit-vscode/blob/ad2164b2937d324681f9504cb5a05d153c70eada/packages/core/src/codewhisperer/util/diagnosticsUtil.ts

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@liumofei-amazon liumofei-amazon requested a review from a team as a code owner June 26, 2025 00:15
@github-actions
Copy link

github-actions bot commented Jun 26, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

leigaol
leigaol reviewed Jun 26, 2025
View reviewed changes
packages/amazonq/src/app/inline/completion.ts Outdated
// TODO: also log the seen state for other suggestions in session
// Calculate timing metrics before diagnostic delay
const totalSessionDisplayTime = Date.now() - requestStartTime
await new Promise((resolve) => setTimeout(resolve, 1000))
Copy link
Contributor

@leigaol leigaol Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just use sleep here

leigaol
leigaol reviewed Jun 26, 2025
View reviewed changes
packages/amazonq/src/app/inline/completion.ts Outdated
) => {
// TODO: also log the seen state for other suggestions in session
// Calculate timing metrics before diagnostic delay
const totalSessionDisplayTime = Date.now() - requestStartTime
Copy link
Contributor

@leigaol leigaol Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use performance.now()

@liumofei-amazon liumofei-amazon changed the title feat: send ide diagnostics for inline completions feat(amazonq): send ide diagnostics for inline completions Jun 26, 2025
leigaol
leigaol reviewed Jun 26, 2025
View reviewed changes
@laileni-aws laileni-aws merged commit 89a455c into aws:master Jul 10, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laileni-aws laileni-aws laileni-aws approved these changes

+1 more reviewer

@leigaol leigaol leigaol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liumofei-amazon @leigaol @laileni-aws